Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DataNode might OOM by estimating based on MemorySize #34203

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #34136
pr: #34201

See also: milvus-io#34136
pr: milvus-io#34201

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 26, 2024
Copy link
Contributor

mergify bot commented Jun 26, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.53%. Comparing base (fc6bd38) to head (26b2dfd).
Report is 18 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34203      +/-   ##
==========================================
- Coverage   81.82%   72.53%   -9.30%     
==========================================
  Files        1010     1010              
  Lines      130787   130968     +181     
==========================================
- Hits       107021    94999   -12022     
- Misses      19766    31959   +12193     
- Partials     4000     4010      +10     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.38% <100.00%> (+<0.01%) ⬆️
internal/datanode/compaction/l0_compactor.go 91.86% <92.59%> (-0.73%) ⬇️

... and 226 files with indirect coverage changes

@tedxu
Copy link
Collaborator

tedxu commented Jul 2, 2024

/lgtm

@congqixia congqixia added this to the 2.4.6 milestone Jul 4, 2024
@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0f1915e into milvus-io:2.4 Jul 4, 2024
10 of 12 checks passed
@XuanYang-cn XuanYang-cn deleted the cp24/fix-estimation branch July 4, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants