Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: retry etcd server start with 3 default retries #34208

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

charleskakumanu
Copy link
Contributor

Added retry method and unit test cases for retrying etcd server start.
New to open source and Go language. Please reject if this is not the requirement/ specify the modifications needed in code.
issue : #17569

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 26, 2024
Copy link
Contributor

mergify bot commented Jun 26, 2024

@charleskakumanu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 26, 2024
Copy link
Contributor

mergify bot commented Jun 26, 2024

@charleskakumanu

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@charleskakumanu charleskakumanu changed the title retry etcd server start with 3 default retries enhance: retry etcd server start with 3 default retries Jun 26, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Jun 26, 2024
… between tries

Signed-off-by: Charles Kakumanu <charles_kakumanu@apple.com>
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jun 26, 2024
Copy link
Contributor

mergify bot commented Jun 26, 2024

@charleskakumanu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@charleskakumanu
Copy link
Contributor Author

/run-cpu-e2e

@charleskakumanu
Copy link
Contributor Author

/assign @xiaofan-luan

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleskakumanu, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jul 5, 2024
@sre-ci-robot sre-ci-robot merged commit 05df709 into milvus-io:master Jul 5, 2024
10 checks passed
@amaypatil
Copy link

@xiaofan-luan which release are we targetting this ? I see it was merged with master as well.

@xiaofan-luan
Copy link
Contributor

If we cherry pick this to 2.4 branch, we can release at 2.4.8

Other than that it will be 2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants