-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: retry etcd server start with 3 default retries #34208
Conversation
@charleskakumanu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
… between tries Signed-off-by: Charles Kakumanu <charles_kakumanu@apple.com>
9cb4685
to
ed51313
Compare
@charleskakumanu E2e jenkins job failed, comment |
/run-cpu-e2e |
/assign @xiaofan-luan |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charleskakumanu, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xiaofan-luan which release are we targetting this ? I see it was merged with master as well. |
If we cherry pick this to 2.4 branch, we can release at 2.4.8 Other than that it will be 2.5 |
Added retry method and unit test cases for retrying etcd server start.
New to open source and Go language. Please reject if this is not the requirement/ specify the modifications needed in code.
issue : #17569