Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [skip e2e] use disk ann when os is ubuntu #34236

Merged
merged 1 commit into from
Jun 27, 2024
Merged

enhance: [skip e2e] use disk ann when os is ubuntu #34236

merged 1 commit into from
Jun 27, 2024

Conversation

yellow-shine
Copy link
Collaborator

@yellow-shine yellow-shine commented Jun 27, 2024 •
edited
Loading

issue: #34222

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 27, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 27, 2024
@yellow-shine yellow-shine mentioned this pull request Jun 27, 2024
Closed
@mergify mergify bot added the ci-passed label Jun 27, 2024
@elstic
Copy link
Contributor

elstic commented Jun 27, 2024

@LoveEachDay help review~

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jun 27, 2024
@yellow-shine yellow-shine force-pushed the ubuntu branch 2 times, most recently from 52a7e49 to 7ebcc66 Compare June 27, 2024 10:13
@yellow-shine yellow-shine mentioned this pull request Jun 27, 2024
Merged
@yellow-shine
enhance: [skip e2e] use disk ann when os is ubuntu, rocky or amazon
60439cb 
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jun 27, 2024
@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samhuang-z, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b14482b into milvus-io:master Jun 27, 2024
5 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jun 27, 2024
@yellow-shine
enhance: [skip e2e] use disk ann when os is ubuntu, rocky or amazon (#…
7b4c1a0 
…34244)

pr: #34236

Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@yellow-shine
enhance: [skip e2e] use disk ann when os is ubuntu (milvus-io#34236)
43b10ae 
issue: milvus-io#34222

Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

@yhmo yhmo Awaiting requested review from yhmo

Assignees

@yanliang567 yanliang567

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yellow-shine @elstic @yanliang567 @sre-ci-robot