Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reduce duplicate PKs in segcore #34267

Merged
merged 5 commits into from
Jul 1, 2024
Merged

fix: Reduce duplicate PKs in segcore #34267

merged 5 commits into from
Jul 1, 2024

Conversation

bigsheeper
Copy link
Contributor

issue: #34247

@bigsheeper
fix: Reduce duplicate PKs in segcore
ad4fc40 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 28, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
update
5cd1bf9 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@zhagnlu
Copy link
Collaborator

zhagnlu commented Jun 28, 2024

/lgtm

@bigsheeper
update
0f936eb 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Jun 28, 2024
@bigsheeper
Merge branch 'master' of https://github.com/milvus-io/milvus into 240…
d6aac26 
…6-fix-query
@bigsheeper
fix ut
c35af35 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@mergify mergify bot added the ci-passed label Jul 1, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.50%. Comparing base (e5d691d) to head (c35af35).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34267      +/-   ##
==========================================
+ Coverage   80.44%   80.50%   +0.06%     
==========================================
  Files        1086     1081       -5     
  Lines      137670   138153     +483     
==========================================
+ Hits       110744   111218     +474     
- Misses      22756    22774      +18     
+ Partials     4170     4161       -9
Files Coverage Δ
internal/core/src/segcore/InsertRecord.h 91.11% <100.00%> (-1.48%) ⬇️

... and 236 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 1, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 734415b into milvus-io:master Jul 1, 2024
11 of 12 checks passed
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label Jul 1, 2024
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Jul 1, 2024
@bigsheeper
fix: Reduce duplicate PKs in segcore (milvus-io#34267)
ce28dee 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper bigsheeper mentioned this pull request Jul 1, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Jul 1, 2024
@bigsheeper
fix: Reduce duplicate PKs in segcore (#34267) (#34302)
3c5ad49 
issue: issue: #34247

pr: #34267

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@czs007 czs007 removed the PR | need cherry-pick need cherry pick to other branches label Jul 2, 2024
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@bigsheeper @yellow-shine
fix: Reduce duplicate PKs in segcore (milvus-io#34267)
b7c0147 
issue: milvus-io#34247

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Jul 12, 2024
@bigsheeper
fix: Reduce duplicate PKs in segcore (milvus-io#34267) (milvus-io#34302)
17b7671 
issue: issue: milvus-io#34247

pr: milvus-io#34267

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Jul 12, 2024
@bigsheeper
fix: Reduce duplicate PKs in segcore (milvus-io#34267) (milvus-io#34302)
9f7f3ac 
issue: issue: milvus-io#34247

pr: milvus-io#34267

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Aug 5, 2024
@bigsheeper
fix: Reduce duplicate PKs in segcore (milvus-io#34267) (milvus-io#34302)
c97d794 
issue: issue: milvus-io#34247

pr: milvus-io#34267

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper bigsheeper mentioned this pull request Aug 5, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Aug 7, 2024
@bigsheeper
fix: [2.3] Reduce duplicate PKs in segcore (#34267) (#35291)
52fcd3f 
issue: #34247

pr: #34267

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@zhagnlu zhagnlu

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bigsheeper @zhagnlu @czs007 @sre-ci-robot