Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Check segment existence when FlushSegments and add some key logs (#34438) #34472

Merged

Conversation

bigsheeper
Copy link
Contributor

Check if the segment exists during FlushSegments and add some key logs in write path.

issue: #34255

pr: #34438

…logs (milvus-io#34438)

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 8, 2024
Copy link
Contributor

mergify bot commented Jul 8, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.42%. Comparing base (014820e) to head (839d3d3).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34472      +/-   ##
==========================================
+ Coverage   80.78%   84.42%   +3.64%     
==========================================
  Files        1046      786     -260     
  Lines      136101   112422   -23679     
==========================================
- Hits       109945    94914   -15031     
+ Misses      21948    13305    -8643     
+ Partials     4208     4203       -5     
Files Coverage Δ
internal/datanode/flow_graph_dd_node.go 92.63% <100.00%> (+0.09%) ⬆️
internal/datanode/syncmgr/task.go 100.00% <100.00%> (ø)
pkg/mq/msgdispatcher/dispatcher.go 96.62% <100.00%> (-0.68%) ⬇️
pkg/mq/msgdispatcher/manager.go 94.57% <100.00%> (-2.40%) ⬇️
internal/datanode/writebuffer/write_buffer.go 85.97% <50.00%> (-0.05%) ⬇️

... and 294 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jul 8, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented Jul 8, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Contributor

czs007 commented Jul 8, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 8, 2024
@sre-ci-robot sre-ci-robot merged commit 0d7ba81 into milvus-io:2.4 Jul 8, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants