Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:[cherry-pick] Fix compaction start time 2.4 #34504

Closed
wants to merge 2 commits into from
Closed

fix:[cherry-pick] Fix compaction start time 2.4 #34504

wants to merge 2 commits into from

Conversation

wayblink
Copy link
Collaborator

@wayblink wayblink commented Jul 9, 2024

bug: #34497 #34498
pr: #34496

@wayblink
fix compaction task startTime is 0
c56d5c3 
Signed-off-by: wayblink <anyang.wang@zilliz.com>
@wayblink
fix wrong compaction task num in log
09109b8 
Signed-off-by: wayblink <anyang.wang@zilliz.com>
@wayblink wayblink changed the base branch from master to 2.4 July 9, 2024 02:10
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 9, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayblink
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 9, 2024

@wayblink Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/bug Issues or changes related a bug labels Jul 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 9, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@wayblink wayblink closed this Jul 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 9, 2024

⚠️ The sha of the head commit of this PR conflicts with #34505. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoiasd aoiasd Awaiting requested review from aoiasd

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees
No one assigned
Labels
kind/bug Issues or changes related a bug needs-dco DCO is missing in this pull request. size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wayblink @sre-ci-robot