Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unstable UT for level0 deletion #34524

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: unstable UT for level0 deletion #34524

merged 1 commit into from
Jul 11, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Jul 9, 2024 •
edited
Loading

issue: #34533

@jaime0815
fix: unstable UT for level0 deletion
8dfc385 
Signed-off-by: jaime <yun.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 9, 2024
@jaime0815 jaime0815 mentioned this pull request Jul 9, 2024
Merged
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 9, 2024

@jaime0815 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.69%. Comparing base (eeb03a0) to head (8dfc385).
Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34524      +/-   ##
==========================================
+ Coverage   79.76%   80.69%   +0.93%     
==========================================
  Files        1127     1127              
  Lines      139415   139424       +9     
==========================================
+ Hits       111203   112510    +1307     
+ Misses      23919    22629    -1290     
+ Partials     4293     4285       -8

see 96 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3b62138 into milvus-io:master Jul 11, 2024
11 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 11, 2024
@jaime0815
fix: unstable UT for level0 deletion (#34525)
bfd386a 
issue: #34533
pr: #34524

Signed-off-by: jaime <yun.zhang@zilliz.com>
@jaime0815 jaime0815 deleted the fix-unstable-ut-79-m branch July 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@yah01 yah01 Awaiting requested review from yah01

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaime0815 @czs007 @sre-ci-robot