Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Refine clustering compaction latency metrics #34528

Merged
merged 1 commit into from
Jul 11, 2024
Merged

enhance: Refine clustering compaction latency metrics #34528

merged 1 commit into from
Jul 11, 2024

Conversation

wayblink
Copy link
Collaborator

@wayblink wayblink commented Jul 9, 2024

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 9, 2024
@wayblink
Refine clustering compaction latency metrics
6e7389b 
Signed-off-by: wayblink <anyang.wang@zilliz.com>
@wayblink wayblink mentioned this pull request Jul 9, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 9, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.67%. Comparing base (eae4dfc) to head (6e7389b).
Report is 20 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34528      +/-   ##
==========================================
- Coverage   84.35%   80.67%   -3.68%     
==========================================
  Files         858     1127     +269     
  Lines      115248   139270   +24022     
==========================================
+ Hits        97212   112357   +15145     
- Misses      13734    22627    +8893     
+ Partials     4302     4286      -16
Files Coverage Δ
internal/datacoord/compaction_task_clustering.go 47.33% <100.00%> (ø)
pkg/metrics/datacoord_metrics.go 65.07% <ø> (ø)

... and 302 files with indirect coverage changes

@wayblink
Copy link
Collaborator Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 10, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fd3da90 into milvus-io:master Jul 11, 2024
12 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 11, 2024
@wayblink
enhance: [cherry-pick] Refine clustering compaction latency metrics (#…
9dc98ac 
…34539)

issue: #34527
pr: #34528

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@xige-16 xige-16 Awaiting requested review from xige-16

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wayblink @czs007 @sre-ci-robot