-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent dispatcher merging if curTs is 0 #34562
Conversation
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34562 +/- ##
===========================================
+ Coverage 71.48% 84.37% +12.88%
===========================================
Files 1127 858 -269
Lines 139271 115155 -24116
===========================================
- Hits 99556 97158 -2398
+ Misses 35426 13706 -21720
- Partials 4289 4291 +2
|
/lgtm |
When the main dispatcher has not yet consumed data, curTs is 0. During this time, merging dispatchers should not be allowed; otherwise, the data of the solo dispatcher will be skipped. issue: milvus-io#34255 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
When the main dispatcher has not yet consumed data, curTs is 0. During this time, merging dispatchers should not be allowed; otherwise, the data of the solo dispatcher will be skipped. issue: milvus-io#34255 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…us-io#34563) When the main dispatcher has not yet consumed data, curTs is 0. During this time, merging dispatchers should not be allowed; otherwise, the data of the solo dispatcher will be skipped. issue: milvus-io#34255 pr: milvus-io#34562 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…us-io#34563) When the main dispatcher has not yet consumed data, curTs is 0. During this time, merging dispatchers should not be allowed; otherwise, the data of the solo dispatcher will be skipped. issue: milvus-io#34255 pr: milvus-io#34562 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
When the main dispatcher has not yet consumed data, curTs is 0. During this time, merging dispatchers should not be allowed; otherwise, the data of the solo dispatcher will be skipped.
issue: #34255