Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add the seal segment when dispatch delete msgs #34565

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jul 10, 2024

/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines. labels Jul 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 10, 2024
@SimFG
Copy link
Contributor Author

SimFG commented Jul 10, 2024

rerun ut

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.68%. Comparing base (3c70463) to head (73038c4).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34565      +/-   ##
==========================================
+ Coverage   71.48%   80.68%   +9.19%     
==========================================
  Files        1127     1127              
  Lines      139271   139325      +54     
==========================================
+ Hits        99556   112409   +12853     
+ Misses      35426    22626   -12800     
- Partials     4289     4290       +1     
Files Coverage Δ
internal/datanode/writebuffer/l0_write_buffer.go 93.02% <100.00%> (ø)
pkg/config/env_source.go 96.96% <ø> (ø)

... and 225 files with indirect coverage changes

@sre-ci-robot sre-ci-robot merged commit b58a561 into milvus-io:master Jul 10, 2024
12 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 10, 2024
/kind improvement
- pr: #34565

Signed-off-by: SimFG <bang.fu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants