Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable milvus.yaml check #34567

Merged
merged 7 commits into from
Jul 25, 2024
Merged

fix: enable milvus.yaml check #34567

merged 7 commits into from
Jul 25, 2024

Conversation

tedxu
Copy link
Collaborator

@tedxu tedxu commented Jul 10, 2024 •
edited
Loading

See #32168

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug do-not-merge/missing-related-issue labels Jul 10, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 10, 2024

@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify mergify bot added the ci-passed label Jul 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (d294fdd) to head (3a4806a).
Report is 34 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34567      +/-   ##
==========================================
+ Coverage   80.84%   80.86%   +0.02%     
==========================================
  Files        1175     1180       +5     
  Lines      142066   142367     +301     
==========================================
+ Hits       114849   115126     +277     
- Misses      22826    22838      +12     
- Partials     4391     4403      +12
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.54% <100.00%> (+<0.01%) ⬆️

... and 108 files with indirect coverage changes

@mergify mergify bot removed the ci-passed label Jul 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Collaborator Author

tedxu commented Jul 11, 2024

/run-cpu-e2e

@mergify mergify bot added ci-passed and removed ci-passed labels Jul 11, 2024
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Jul 12, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Jul 12, 2024
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jul 16, 2024
This was referenced Jul 17, 2024
Merged
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 17, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Collaborator Author

tedxu commented Jul 17, 2024

/run-cpu-e2e

@mergify mergify bot removed the ci-passed label Jul 18, 2024
@mergify mergify bot added the ci-passed label Jul 21, 2024
@tedxu
fix: enabling milvus.yaml check by avoiding go list
3479246 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu
update milvus.yaml
3126cd9 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu
surpress logs
8df8de7 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu
run cmd/tools tests first
b398e71 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu
skip check of etcd endpoints
80f4ec2 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu
skip check of minio and pulsar endpoints
8551ed2 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu
skip check of minio and pulsar endpoints
3a4806a 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@mergify mergify bot added ci-passed and removed ci-passed labels Jul 22, 2024
congqixia
congqixia approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 63f0154 into milvus-io:master Jul 25, 2024
11 of 12 checks passed
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
@tedxu @sumitd2
fix: enable milvus.yaml check (milvus-io#34567)
24ecd98 
See milvus-io#32168

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@czs007 czs007 Awaiting requested review from czs007

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@congqixia congqixia

Labels
approved area/compilation area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tedxu @sre-ci-robot @congqixia