Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Refine default histogram metric bucket #34580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LoveEachDay
Copy link
Contributor

@LoveEachDay LoveEachDay commented Jul 10, 2024

/kind improvement

pr: #34580

Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jul 10, 2024
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 10, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LoveEachDay
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jul 10, 2024

@LoveEachDay

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@LoveEachDay LoveEachDay changed the title Refine default histogram metric bucket enhance: Refine default histogram metric bucket Jul 10, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Jul 10, 2024
Copy link
Contributor

mergify bot commented Jul 10, 2024

@LoveEachDay E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@LoveEachDay
Copy link
Contributor Author

/run-cpu-e2e

sre-ci-robot pushed a commit that referenced this pull request Jul 11, 2024
/kind improvement
pr: #34580

Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jul 12, 2024
/kind improvement

pr: #34580

Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
jaime0815 pushed a commit to jaime0815/milvus that referenced this pull request Jul 12, 2024
/kind improvement
pr: milvus-io#34580

Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
jaime0815 pushed a commit to jaime0815/milvus that referenced this pull request Jul 12, 2024
/kind improvement
pr: milvus-io#34580

Signed-off-by: jaime <yun.zhang@zilliz.com>

Co-authored-by: Edward Zeng <jie.zeng@zilliz.com>
Copy link

stale bot commented Aug 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines. stale indicates no udpates for 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants