Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add back compactionTaskNum metrics #34583

Merged

Conversation

XuanYang-cn
Copy link
Contributor

Fix L0 compaction task recover unable to set segment not isCompacting

See also: #34460

Fix L0 compaction task recover unable to set segment
not isCompacting

See also: milvus-io#34460

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 10, 2024
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Jul 10, 2024
Fix L0 compaction task recover unable to set segment
not isCompacting

See also: milvus-io#34460
pr: milvus-io#34583

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jul 10, 2024
Fix L0 compaction task recover unable to set segment
not isCompacting

See also: #34460
pr: #34583

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify mergify bot added the ci-passed label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 69.90291% with 31 lines in your changes missing coverage. Please review.

Project coverage is 80.66%. Comparing base (3c70463) to head (6bbcdd6).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34583      +/-   ##
==========================================
+ Coverage   71.48%   80.66%   +9.18%     
==========================================
  Files        1127     1127              
  Lines      139271   139336      +65     
==========================================
+ Hits        99556   112400   +12844     
+ Misses      35426    22642   -12784     
- Partials     4289     4294       +5     
Files Coverage Δ
internal/datacoord/compaction_policy_l0.go 97.80% <100.00%> (-0.05%) ⬇️
internal/datacoord/meta.go 86.16% <100.00%> (+0.17%) ⬆️
internal/metastore/kv/datacoord/kv_catalog.go 75.13% <100.00%> (ø)
internal/datacoord/compaction_task_clustering.go 47.74% <0.00%> (+0.40%) ⬆️
internal/datacoord/compaction_task_l0.go 63.33% <33.33%> (-1.40%) ⬇️
internal/datacoord/compaction_trigger_v2.go 72.57% <36.36%> (+0.31%) ⬆️
internal/datacoord/compaction_task_mix.go 66.97% <42.85%> (-2.61%) ⬇️
internal/datacoord/compaction.go 70.93% <84.74%> (-0.31%) ⬇️

... and 227 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d7a3697 into milvus-io:master Jul 11, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants