Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Add param item for segmentFlushInterval (#34629) #34663

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #34629
See also #28817

Add paramitem for segment flush interval

See also milvus-io#28817

Add paramitem for segment flush interval

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels Jul 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (4e02e57) to head (02b7ead).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #34663       +/-   ##
===========================================
+ Coverage   69.74%   84.42%   +14.68%     
===========================================
  Files        1045      786      -259     
  Lines      136250   112545    -23705     
===========================================
- Hits        95021    95019        -2     
+ Misses      37018    13310    -23708     
- Partials     4211     4216        +5     
Files Coverage Δ
internal/datacoord/segment_allocation_policy.go 87.95% <100.00%> (ø)
internal/datacoord/segment_info.go 87.09% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.49% <100.00%> (+<0.01%) ⬆️

... and 288 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants