Support logging to stdout #4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengjun1985
force-pushed
the
log_stdout
branch
2 times, most recently
from
efdf1aa
to
67f3c2e
Compare
Signed-off-by: shengjun.li <shengjun.li@zilliz.com>
shengjun1985
force-pushed
the
log_stdout
branch
from
67f3c2e
to
ce185c2
Compare
wxyucs
approved these changes
Feb 24, 2021
yhmo
approved these changes
Feb 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #4738 +/- ##
==========================================
- Coverage 86.91% 85.92% -1.00%
==========================================
Files 434 404 -30
Lines 26687 24606 -2081
==========================================
- Hits 23196 21143 -2053
+ Misses 3491 3463 -28
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shengjun.li shengjun.li@zilliz.com
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #4735, #3977, #3208
What this PR does / why we need it:
(1) Add 2 config items to control log output
(2) Not to create log file if it is unnecessary
Special notes for your reviewer:
Not Available
Additional documentation (e.g. design docs, usage docs, etc.):
new config items in server_config.yaml