Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize code under storage #6335

Merged

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Jul 7, 2021

issue: #6349
Signed-off-by: yudong.cai yudong.cai@zilliz.com

…yload/GetStringFromPayload

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
…stamp()

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jul 7, 2021
@mergify mergify bot added the ci-passed label Jul 7, 2021
…ad/GetOneStringFromPayload

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@mergify mergify bot added ci-passed and removed ci-passed labels Jul 7, 2021
Copy link
Contributor

@neza2017 neza2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, neza2017

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3387b07 into milvus-io:master Jul 7, 2021
@cydrain cydrain deleted the caiyd_optimize_storage_wrapper branch July 7, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants