Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save binlog path in SegmentInfo #6590

Merged
merged 1 commit into from Aug 19, 2021

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jul 16, 2021

issue: #6589
Signed-off-by: sunby bingyi.sun@zilliz.com

@sre-ci-robot sre-ci-robot added component/datacoord size/XXL Denotes a PR that changes 1000+ lines. labels Jul 16, 2021
@sunby sunby force-pushed the save_binlog_in_segmentinfo branch from 2806829 to 225de4d Compare July 19, 2021 02:05
@mergify mergify bot added the ci-passed label Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #6590 (118cefb) into master (c2a4bd3) will increase coverage by 0.02%.
The diff coverage is 70.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6590      +/-   ##
==========================================
+ Coverage   42.86%   42.89%   +0.02%     
==========================================
  Files         219      218       -1     
  Lines       26018    25964      -54     
==========================================
- Hits        11153    11137      -16     
+ Misses      13480    13455      -25     
+ Partials     1385     1372      -13     
Impacted Files Coverage Δ
internal/datacoord/datanode_helper.go 80.00% <ø> (ø)
internal/datanode/data_node.go 54.04% <0.00%> (ø)
internal/datanode/data_sync_service.go 48.78% <0.00%> (ø)
internal/datanode/flow_graph_message.go 0.00% <ø> (ø)
internal/datanode/flow_graph_insert_buffer_node.go 74.52% <33.33%> (ø)
internal/datacoord/meta.go 73.03% <51.85%> (-1.52%) ⬇️
internal/datacoord/grpc_services.go 59.02% <69.23%> (+1.93%) ⬆️
internal/datacoord/segment_info.go 87.09% <88.88%> (+0.88%) ⬆️
internal/datacoord/server.go 63.20% <93.33%> (+3.00%) ⬆️
internal/datacoord/cluster.go 79.15% <0.00%> (-1.77%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a4bd3...118cefb. Read the comment docs.

@sunby sunby force-pushed the save_binlog_in_segmentinfo branch from 225de4d to 243e70e Compare July 19, 2021 06:09
@mergify mergify bot removed the ci-passed label Jul 19, 2021
@sunby sunby force-pushed the save_binlog_in_segmentinfo branch 2 times, most recently from bdc7733 to f09f6a0 Compare July 24, 2021 02:56
@sunby sunby force-pushed the save_binlog_in_segmentinfo branch from f09f6a0 to c3039b0 Compare July 28, 2021 03:47
@mergify mergify bot added the ci-passed label Jul 28, 2021
@sunby sunby added the kind/enhancement Issues or changes related to enhancement label Jul 31, 2021
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@czs007
Copy link
Contributor

czs007 commented Aug 16, 2021

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, sunby, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

issue: milvus-io#6589
Signed-off-by: sunby <bingyi.sun@zilliz.com>
@sunby sunby force-pushed the save_binlog_in_segmentinfo branch from 2d1844c to 118cefb Compare August 17, 2021 11:20
@mergify mergify bot added the ci-passed label Aug 17, 2021
@czs007
Copy link
Contributor

czs007 commented Aug 19, 2021

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants