Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a seal policy which restricts the lifetime of a segment #7172

Merged
merged 1 commit into from Aug 20, 2021

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Aug 19, 2021

issue: #7164
Signed-off-by: sunby bingyi.sun@zilliz.com

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Aug 19, 2021
@sunby sunby force-pushed the add_sgement_seal_by_lifetime branch from 77d885e to 058d7b2 Compare August 19, 2021 06:52
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #7172 (66bf6b3) into master (4f7c3e7) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7172      +/-   ##
==========================================
+ Coverage   42.72%   42.80%   +0.07%     
==========================================
  Files         224      224              
  Lines       26441    26451      +10     
==========================================
+ Hits        11297    11322      +25     
+ Misses      13745    13730      -15     
  Partials     1399     1399              
Impacted Files Coverage Δ
internal/datacoord/policy.go 50.00% <ø> (ø)
internal/datacoord/segment_allocation_policy.go 71.42% <100.00%> (+9.20%) ⬆️
internal/datacoord/segment_manager.go 59.74% <100.00%> (+0.60%) ⬆️
internal/rootcoord/task.go 78.80% <0.00%> (-0.84%) ⬇️
internal/indexcoord/index_coord.go 64.55% <0.00%> (-0.12%) ⬇️
...ternal/util/rocksmq/server/rocksmq/rocksmq_impl.go 50.78% <0.00%> (ø)
internal/datacoord/server.go 63.32% <0.00%> (+0.11%) ⬆️
internal/datacoord/meta.go 73.48% <0.00%> (+0.44%) ⬆️
internal/msgstream/mq_msgstream.go 71.96% <0.00%> (+0.93%) ⬆️
internal/datacoord/segment_info.go 88.23% <0.00%> (+1.13%) ⬆️
... and 3 more

@mergify mergify bot added the ci-passed label Aug 19, 2021
@sunby sunby changed the title Add a seal policy which restricts the lifetime of a segment. Add a seal policy which restricts the lifetime of a segment Aug 19, 2021
@mergify mergify bot added ci-passed and removed ci-passed labels Aug 19, 2021
@sunby sunby force-pushed the add_sgement_seal_by_lifetime branch from 058d7b2 to 83a01ca Compare August 19, 2021 10:53
@mergify mergify bot removed the ci-passed label Aug 19, 2021
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

issue: milvus-io#7164
Signed-off-by: sunby <bingyi.sun@zilliz.com>
@sunby sunby force-pushed the add_sgement_seal_by_lifetime branch from 83a01ca to 66bf6b3 Compare August 20, 2021 06:38
@sre-ci-robot sre-ci-robot removed the lgtm label Aug 20, 2021
@mergify mergify bot added ci-passed and removed ci-passed labels Aug 20, 2021
@czs007
Copy link
Contributor

czs007 commented Aug 20, 2021

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants