Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add knowhere.yaml to support knowhere configuration #7967

Merged
merged 1 commit into from Sep 18, 2021

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Sep 15, 2021

Signed-off-by: yudong.cai yudong.cai@zilliz.com

@cydrain
Copy link
Contributor Author

cydrain commented Sep 15, 2021

/kind improvement

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. kind/improvement Changes related to something improve, likes ut and code refactor labels Sep 15, 2021
@cydrain cydrain force-pushed the caiyd_add_knowhere_yaml branch 2 times, most recently from 430775f to 9baa1c2 Compare September 15, 2021 09:27
@wxyucs
Copy link
Member

wxyucs commented Sep 15, 2021

/lgtm
/approve

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #7967 (a524b73) into master (fa00f1f) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7967   +/-   ##
=======================================
  Coverage   78.69%   78.70%           
=======================================
  Files         252      252           
  Lines       31732    31733    +1     
=======================================
+ Hits        24973    24976    +3     
- Misses       4793     4796    +3     
+ Partials     1966     1961    -5     
Impacted Files Coverage Δ
internal/querynode/param_table.go 61.94% <40.00%> (-1.45%) ⬇️
internal/proxy/task.go 73.16% <100.00%> (ø)
internal/querycoord/task.go 66.73% <0.00%> (-6.51%) ⬇️
...nternal/util/rocksmq/client/rocksmq/client_impl.go 83.87% <0.00%> (-6.46%) ⬇️
internal/querynode/cgo_helper.go 79.41% <0.00%> (-5.89%) ⬇️
internal/querynode/streaming.go 75.25% <0.00%> (-2.07%) ⬇️
internal/indexcoord/index_coord.go 78.35% <0.00%> (-1.74%) ⬇️
internal/querycoord/meta.go 63.15% <0.00%> (-0.88%) ⬇️
...ternal/util/rocksmq/server/rocksmq/rocksmq_impl.go 69.67% <0.00%> (-0.76%) ⬇️
internal/querynode/segment.go 78.29% <0.00%> (-0.47%) ⬇️
... and 9 more

Copy link
Member

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
Copy link
Member

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, scsven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 83bf9c5 into milvus-io:master Sep 18, 2021
@cydrain cydrain deleted the caiyd_add_knowhere_yaml branch September 18, 2021 02:41
xiyichan pushed a commit to xiyichan/milvus that referenced this pull request Sep 26, 2021
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants