Iced 0.5 upgrade #24
Merged
Iced 0.5 upgrade #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the theme also lives there.
This reverts commit 02e3216.
This reverts commit 91b1570.
…as a pain to deal with. Having the mouse and draw logic under a single roof is going to be easier and cleaner to deal with.
… - the mouse_interaction and draw implmentations have been consolidated into the component itself.
|
Excellent! Great job and thanks for doing this. Will merge now and we can perform any remaining fixes and tweaks as we go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Incantation of Sorts:
It took me some time to figure out a quaint way to migrate the custom widgets. Alas, the path is alight! This deprecates the out of date method of styling (src/gui/style.rs). The new method of styling is implemented under the theme module (core/src/theme). I still have more styles to migrate from the original style.rs file. I'll be doing that as we continue. Our styling should be much more maintainable now instead of having them in one ginormous file. Aside from this, the other major improvement was that this eliminates the need to pass the color_palette param everywhere, and therefore, it was dropped.