Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Presentation Template #43

Closed
RyanHu1208 opened this issue Jan 18, 2019 · 4 comments
Closed

Add Presentation Template #43

RyanHu1208 opened this issue Jan 18, 2019 · 4 comments
Labels
design Anything related to design/UX fixed

Comments

@RyanHu1208
Copy link
Contributor

hi @lehnberg

this is from noahyeh at gitter
please take a look

https://github.com/RyanHu1208/grin-pm/tree/master/presentations/templates

thank you

@lehnberg
Copy link
Collaborator

@RyanHu1208 looks good, thank you very much!

Suggestions:

  • rename GrinDeckTemplates.md to README.md
  • add 'description' column with a brief description of your template

Makes sense? :)

@0xmichalis
Copy link
Contributor

@lehnberg there is a README.md file in grin-pm already. Maybe use something like PRESENTATIONS.md and link to it from README.md?

@0xmichalis
Copy link
Contributor

@lehnberg there is a README.md file in grin-pm already. Maybe use something like PRESENTATIONS.md and link to it from README.md?

OK, seems like the presentations table is already part of README.md

https://github.com/mimblewimble/grin-pm#presentations

@lehnberg
Copy link
Collaborator

Oh lol... didn't realise this was an issue. @RyanHu1208 this looks good - can you open a pull request merging your proposed changes?

@lehnberg lehnberg added fixed design Anything related to design/UX labels Feb 5, 2019
@lehnberg lehnberg closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Anything related to design/UX fixed
Projects
None yet
Development

No branches or pull requests

3 participants