Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft at release process #292

Merged
merged 6 commits into from Jul 23, 2020

Conversation

quentinlesceller
Copy link
Member

@quentinlesceller quentinlesceller commented May 12, 2020

Link to rendered markdown

Create a new release_process.md file at the root of the repository with all the steps to follow for every release.

@j01tz
Copy link
Member

j01tz commented May 12, 2020

Great idea! This should definitely help improve the release process.

A few thoughts/questions:

  • Is it possible to make the checksum validation and review process before merging to the site more explicit?
  • Does it make sense to include a step to check to ensure that there are no dependencies that need to be upgraded as the result of an upstream security fix or would that be out of scope for the release checklist itself?
  • Maybe the above points could be condensed to a 'manual/security review' step that includes multiparty manual checksum verification/review as well as a brief manual dependency review which could be extended over time with more automated tests like fuzzers etc

@lehnberg
Copy link
Collaborator

Great initiative @quentinlesceller, I'm all for this! 👍

Some ideas:

  • How about this document becomes a more specific release_process.md, containing instructions, steps, and meta-data related to our release process, without containing an actual checklist itself? I think the steps you have already outlined is good enough for a first take; and then
  • What if we manage the checklist for each release as individual GitHub issues under grin-pm? We could set up a custom issue template for a "Release checklist" that has all the checklist boxes pre-configured, and have a new issue created for every release that we can tick off boxes against. It could have a specific Release Checklist label, be assigned to team members, and be closed once completed.

Wdyt?

@lehnberg lehnberg mentioned this pull request May 15, 2020
2 tasks
@lehnberg lehnberg mentioned this pull request May 29, 2020
2 tasks
@lehnberg lehnberg mentioned this pull request Jun 13, 2020
1 task
@quentinlesceller
Copy link
Member Author

@Joltz

Does it make sense to include a step to check to ensure that there are no dependencies that need to be upgraded as the result of an upstream security fix or would that be out of scope for the release checklist itself?

This is a very good question but IMO that should be handled before the release (so it does not break anything)

Maybe the above points could be condensed to a 'manual/security review' step that includes multiparty manual checksum verification/review as well as a brief manual dependency review which could be extended over time with more automated tests like fuzzers etc

I think this is the direction I'd like to go definitely 👍

@lehnberg

How about this document becomes a more specific release_process.md, containing instructions, steps, and meta-data related to our release process, without containing an actual checklist itself? I think the steps you have already outlined is good enough for a first take;

Agree modified the document accordingly.

What if we manage the checklist for each release as individual GitHub issues under grin-pm? We could set up a custom issue template for a "Release checklist" that has all the checklist boxes pre-configured, and have a new issue created for every release that we can tick off boxes against. It could have a specific Release Checklist label, be assigned to team members, and be closed once completed.

Good idea, that would be neat 👍

@lehnberg lehnberg mentioned this pull request Jun 28, 2020
1 task
@lehnberg lehnberg mentioned this pull request Jul 9, 2020
1 task
@quentinlesceller
Copy link
Member Author

I just added three requested parts:

  • The branching part and the maintenance branch along with proper versioning for grin and grin-wallet
  • Website blog announcement
  • Forum blog post

Am I missing something @lehnberg ?

@quentinlesceller quentinlesceller changed the title First draft at release checklist First draft at release process Jul 13, 2020
Copy link
Collaborator

@lehnberg lehnberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 SHIP IT 🛳

@lehnberg lehnberg merged commit 51e1266 into mimblewimble:master Jul 23, 2020
@lehnberg lehnberg mentioned this pull request Jul 23, 2020
4 tasks
@quentinlesceller quentinlesceller deleted the release branch July 23, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants