Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cloning and various formating/efficiency improvements #321

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Remove cloning and various formating/efficiency improvements #321

merged 1 commit into from
Feb 4, 2020

Conversation

quentinlesceller
Copy link
Member

Thanks to Clippy :)

@quentinlesceller quentinlesceller added the enhancement New feature or request label Jan 31, 2020
yeastplume
yeastplume approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@yeastplume yeastplume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine (String::from(format!(... etc.. is cringeworthy)

@yeastplume yeastplume merged commit 047ea93 into mimblewimble:master Feb 4, 2020
antiochp pushed a commit to antiochp/grin-wallet that referenced this pull request Aug 7, 2020
@quentinlesceller
Remove cloning and various formating/efficiency improvements (mimblew…
a9043ea 
…imble#321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeastplume yeastplume yeastplume approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quentinlesceller @yeastplume