Skip to content

Commit

Permalink
deadlock risk in check_orphans called from txhashset_write (#3156)
Browse files Browse the repository at this point in the history
  • Loading branch information
antiochp committed Dec 5, 2019
1 parent 52ea906 commit 3a333ae
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions chain/src/chain.rs
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ impl Chain {
}

/// Check for orphans, once a block is successfully added
pub fn check_orphans(&self, mut height: u64) {
fn check_orphans(&self, mut height: u64) {
let initial_height = height;

// Is there an orphan in our orphans that we can now process?
Expand Down Expand Up @@ -999,9 +999,6 @@ impl Chain {

debug!("txhashset_write: replaced our txhashset with the new one");

// Check for any orphan blocks and process them based on the new chain state.
self.check_orphans(header.height + 1);

status.on_done();

Ok(false)
Expand Down

0 comments on commit 3a333ae

Please sign in to comment.