Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify coinbase maturity via output_mmr_size #1203

Merged

Conversation

antiochp
Copy link
Member

@antiochp antiochp commented Jun 26, 2018

We do not need Merkle proofs to spend coinbase outputs.
We only need the output_mmr_size from the block header.

  • verify coinbase maturity via output pos vs. output_mmr_size committed to in block header
  • wallet does not need to be concerned with Merkle proofs or block hashes

TODO -

  • any more cleanup?
  • test with real running nodes

Resolves #1191.
Resolves #1185.

we only need the output_mmr_size from the block header
@yeastplume
Copy link
Member

Very happy with these simplifications if it all works.. refresh_missing_block_hashes in particular is a bit source of slow-down when trying to use the wallet.

@antiochp antiochp changed the title [DNM] verify coinbase maturity via output_mmr_size verify coinbase maturity via output_mmr_size Jun 29, 2018
@antiochp
Copy link
Member Author

Going to merge this.
Tests are all passing on travis.
Testing locally with a couple of nodes indicates this is all still working as expected without needing Merkle proofs on the inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants