Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API server stop #1943

Closed
wants to merge 2 commits into from
Closed

API server stop #1943

wants to merge 2 commits into from

Conversation

garyyu
Copy link
Contributor

@garyyu garyyu commented Nov 7, 2018

Close #1934

@garyyu
Copy link
Contributor Author

garyyu commented Nov 7, 2018

A confusing problem:

		Server::bind(&addr)
		.serve(router)
		.with_graceful_shutdown(rx)

with_graceful_shutdown works in Grin binary, but can't work in test_p2p, function return OK but API port not listening. No idea about the root cause of this.

@hashmap
Copy link
Contributor

hashmap commented Nov 7, 2018

that's where I stopped last time, it also works fine in API tests, I have a loop there to start/stop server twice, works like a charm

@garyyu
Copy link
Contributor Author

garyyu commented Nov 27, 2018

Close for now, since no good solution to fix the
strange problem in #1943 (comment).

@garyyu garyyu closed this Nov 27, 2018
@garyyu garyyu deleted the 1934 branch January 3, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants