Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: avoid display the long file name on txs #2445

Merged
merged 1 commit into from
Jan 22, 2019
Merged

wallet: avoid display the long file name on txs #2445

merged 1 commit into from
Jan 22, 2019

Conversation

garyyu
Copy link
Contributor

@garyyu garyyu commented Jan 22, 2019

Minor improvement on wallet txs display.

Before this PR:

$ grin wallet txs
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 Id  Type        Shared Transaction Id                 Creation Time        Confirmed?  Confirmation Time    Num.    Num.     Amount    Amount   Fee    Net         Tx  
                                                                                                             Inputs  Outputs  Credited  Debited         Difference  Data 
================================================================================================================================================================================================================
 0   Confirmed   None                                  2019-01-19 13:38:50  true        2019-01-19 13:38:50  0       1        60.018    0.0      None   60.018      None 
     Coinbase                                                                                                                                                        
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 1   Sent Tx     43955493-2648-488b-a4fd-1a4e775d1c54  2019-01-21 03:21:43  true        2019-01-21 03:26:24  1       1        59.01     60.018   0.008  -1.008      43955493-2648-488b-a4fd-1a4e775d1c54.grintx 
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

The TxData filename is using the Shared Transaction Id as the name and with fixed extension .grintx. So, perhaps we can just display Yes/None for the TxData status instead of a long filename, to avoid the wrapped lines on laptop screen.

After this PR:

$ grin wallet txs
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 Id  Type        Shared Transaction Id                 Creation Time        Confirmed?  Confirmation Time    Num.    Num.     Amount    Amount   Fee    Net         Tx  
                                                                                                             Inputs  Outputs  Credited  Debited         Difference  Data 
=========================================================================================================================================================================
 0   Confirmed   None                                  2019-01-19 13:38:50  true        2019-01-19 13:38:50  0       1        60.018    0.0      None   60.018      None 
     Coinbase                                                                                                                                                        
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 1   Sent Tx     43955493-2648-488b-a4fd-1a4e775d1c54  2019-01-21 03:21:43  true        2019-01-21 03:26:24  1       1        59.01     60.018   0.008  -1.008      Yes 
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------

@yeastplume
Copy link
Member

Yep, think that's fine

@yeastplume yeastplume merged commit 6b5212e into mimblewimble:master Jan 22, 2019
bitgrin pushed a commit to bitgrin/bitgrin that referenced this pull request Mar 2, 2019
@garyyu garyyu deleted the wallet-txs branch December 11, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants