wallet/owner_api: allow owner API port to be configurable

[RaghavSood]

Adds an owner_api_listen_port to the grin-wallet.toml config to allow the port for the owner API to be changed on a per-wallet basis.

Related issues/PRs:

#2328, #2405

[0xmichalis]

Unrelated to your changes but shouldn't this be ChainTypes::Mainnet?

[ignopeverell]

Looks like it should, yes.

[antiochp]

Good catch! Fixed in #2478

[RaghavSood]

I suspected that too but I wasn't sure if there was a reason for it so I left it as-is. I think there's a few floonet remnants floating around the code, and will likely do another pr to resolve those.

[ignopeverell]

Looks like it should, yes.

[sesam]

@ignopeverell Anything still blocking merging this?
It is a feature that many have asked for. Would be nice if we can ensure it also gets listed in the release notes.

[antiochp]

This looks good.

It does get more awkward to run a wallet for floonet now. We have to remember to explicitly set the port correctly (there is no alternative floonet default config).

In the node global config we override mainnet global config with floonet specific defaults -

grin/config/src/config.rs

Lines 216 to 218 in 92cbfa2

	match *chain_type {
	global::ChainTypes::Mainnet => {}
	global::ChainTypes::Floonet => {

We should be able to do something similar in the wallet config, but I have not looked too closely.

I think this PR is worth merging now. Anybody using floonet can update their local floonet config for now.

[antiochp]

Lets merge this and we can work on the floonet defaults in a separate PR.

[garyyu]

Mike Dallas @mcdallas 22:02
#2475 needs to handle the missing value case otherwise everyone's client will break with the next release

Gary Yu @garyyu 22:09
@mcdallas indeed! and need to add the default config file item.