Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state sync for different partitions #2767

Closed
wants to merge 1 commit into from

Conversation

ignopeverell
Copy link
Contributor

Replacement of the txhahset does a rename to move the content of
the extracted folder. However one can't use rename across
different partitions (my case, /tmp has its own). In case of
failure, this re-extracts the zip to the destination.

Note that I originally tried a copy and delete, but recursively
copying the directory would either add a fair amount of code or
a dedicated dependency. This didn't seem worth (being somewhat of
a degenerate failure case).


name: Pull Request
about: Pull Request checklist
title: ''
labels: ''
assignees: ''


If your PR is a work in progress, please feel free to create it and include a [WIP] tag in the PR name. We encourage everyone to PR early and often so that other developers know what you're working on.

Before submitting your PR for final review, please ensure that it:

  • Includes a proper description of what problems the PR addresses, as well as a detailed explanation as to what it changes
  • Explains whether/how the change is consensus breaking or breaks existing client functionality
  • Contains unit tests exercising new/changed functionality
  • Fully considers the potential impact of the change on other parts of the system
  • Describes how you've tested the change (e.g. against Floonet, etc)
  • Updates any documentation that's affected by the PR

Replacement of the txhahset does a rename to move the content of
the extracted folder. However one can't use rename across
different partitions (my case, `/tmp` has its own). In case of
failure, this re-extracts the zip to the destination.

Note that I originally tried a copy and delete, but recursively
copying the directory would either add a fair amount of code or
a dedicated dependency. This didn't seem worth (being somewhat of
a degenerate failure case).
@ignopeverell ignopeverell added this to the 1.1.0 milestone Apr 20, 2019
@0xmichalis
Copy link
Contributor

However one can't use rename across
different partitions

Wasn't this fixed by @garyyu to use a tmp directory in .grin?

@garyyu
Copy link
Contributor

garyyu commented Apr 22, 2019

Yes, already in 1.1.0 branch by #2753, I will merge it to master.

@ignopeverell
Copy link
Contributor Author

Superseded by #2772

@antiochp antiochp removed this from the 1.1.0 milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants