Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site to new design #147

Merged
merged 7 commits into from
Oct 14, 2019
Merged

Update site to new design #147

merged 7 commits into from
Oct 14, 2019

Conversation

nijynot
Copy link
Member

@nijynot nijynot commented Oct 8, 2019

Updates the site to the new design.
Live example: https://nijynot.github.io/site

@Paouky
Copy link
Contributor

Paouky commented Oct 8, 2019

The "Grin - The Mimblewimble Blockhchain" heading and the content beneath is quite hard to read.
May I suggest switching the font used there altogether and making the heading less dense; bigger, thinner, more space between characters.
I would also try to make these sub-headings more distinguishable. That section just feels like a bit white blur to me.

Great job overall!

@0xb100d
Copy link
Contributor

0xb100d commented Oct 10, 2019

  • I miss the old yellow hand-drawn icons for private scalable and open... though I can see how they might not fit on the new minimal design.

  • very trivial but if the grin logo in the top right spun the other way scrolling down it makes the smile look like a leading arrow a bit more (I think it looks better scrolling up on the page then down as it is)

  • community link now just links to community projects, but I think it should be a drop down including not only projects but the forum, the gitter, etc as the current site does.

  • Wiki/FAQ should be more prominent, maybe another header menu link

  • I think the Friends of Grin and the General Fund could be on the same drop down menu labelled Funding or something (I love the look of both pages though, but don't think they each need a main menu space).

-at the bottom it links to the old domain, now it is grin.mw

-maybe instead of "*" asterisk as the spacer between the text introduction and the next image use the international currency symbol ¤ [https://en.wikipedia.org/wiki/Currency_sign_(typography)]

it looks really good

@nijynot
Copy link
Member Author

nijynot commented Oct 10, 2019

@arad54 Agree with you, the text is a bit hard to parse from first glance. Takes some time to understand it with the new structure and without the yellow hand-drawn icons which @0xb100d mentioned. Maybe we should add some new icons?

@0xb100d

very trivial but if the grin logo in the top right spun the other way scrolling down it makes the smile look like a leading arrow a bit more (I think it looks better scrolling up on the page then down as it is)

A bit on the fence on this one. I think a clockwise rotation makes sense when scrolling down, while a counter-clockwise one would feel a bit unintutitive. I do like the thought of the mouth spinning more like an arrow though!

Wiki/FAQ should be more prominent, maybe another header menu link

Yeah, agreed, should be there. Thought of setting it as Resources, a page that links to the wiki and other content.

I think the Friends of Grin and the General Fund could be on the same drop down menu labelled Funding or something (I love the look of both pages though, but don't think they each need a main menu space).

Ah, I like this! Had some problems with displaying all the pages in a simple way. Introducing dropdowns again is probably the best way manage this.

maybe instead of "*" asterisk as the spacer between the text introduction and the next image use the international currency symbol ¤ [https://en.wikipedia.org/wiki/Currency_sign_(typography)]

Hmm, while I do think it makes sense to add this instead of an asterisk, I don't think it looks as good. Don't really have a strong opinion on this one, so willing to change if anyone wants the ¤.

@Paouky
Copy link
Contributor

Paouky commented Oct 10, 2019

Another way you could go about making the content easier to read, besides adding icons which hardly fit into this design, is to minimize the sub-headings down to a single word like in the previous website (or two words max) and then break a line.

Additionaly, change their font and make em’ distinguisheble by coloring the text white and creating an in-line black color-background (a unique one, that fits the theme, not just simply a block of black). That’s just one way to go about it that popped off in my head. I would demonstrate but I’m on my phone.

@lehnberg
Copy link
Contributor

Merging this now, but this doesn't mean that the work is finished! Continue the feedback and discussion on the tracking issue: #148

@lehnberg lehnberg merged commit f1c2490 into mimblewimble:master Oct 14, 2019
@nijynot nijynot deleted the gh-pages branch October 14, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants