-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syntax error after update version 3.4.0 #159
Comments
Looks to me like release 3.4.0 is using syntax that is not supported by ruby < 2.3? https://github.com/vagrant-libvirt/vagrant-libvirt/runs/4217516069?check_suite_focus=true Rather than try to fix the syntax, should https://github.com/mime-types/ruby-mime-types/blob/main/mime-types.gemspec#L20 be updated to reference 2.3 as the minimum version rather than 2.0? Assuming it's possible do a bugfix release and yank 3.4.0 so that installs on older rubies for some older distros will ignore the more recent releases? While 2.2 is no longer supported for security fixes by the security developers, ruby 2.0 is in centos 7 which has security updates until 2024. |
I will do a bug fix release with this. I won’t be yanking 3.4.0 (for reasons), but this should be quickly addressable. |
Fixed a Ruby < 2.3 incompatibility introduced by the use of standardrb, where `<<-` heredocs were converted to `<<~` heredocs. These have been reverted back to `<<-` with the indentation kept and a `.strip` call to prevent excess whitespace. Resolves #159
mime-types 3.4.1 has been released and should fix this. Please advise if it does not. |
Hello:
Our Project raise syntax error after update version 3.4.0 today, the following is the error message it has showed:
We try to add " in line 26 and 32 in cache.rb:
and it appear another error:
and so do we to registry.rb in line 49, it works:
we are not sure this is right way to fix the error or not, could you please help us confirm this issue? Thank You!
Best Regard!
The text was updated successfully, but these errors were encountered: