Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error message; fix method bugs #569

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Enhance error message; fix method bugs #569

merged 4 commits into from
Oct 8, 2019

Conversation

lrennels
Copy link
Collaborator

@lrennels lrennels commented Oct 7, 2019

No description provided.

Copy link
Collaborator

@rjplevin rjplevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #569 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #569   +/-   ##
======================================
  Coverage    77.4%   77.4%           
======================================
  Files          39      39           
  Lines        2576    2576           
======================================
  Hits         1994    1994           
  Misses        582     582
Impacted Files Coverage Δ
src/core/time_arrays.jl 69.67% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3b37d...247cc00. Read the comment docs.

@lrennels lrennels merged commit dbb40ef into master Oct 8, 2019
@lrennels lrennels deleted the missingdataerror branch October 8, 2019 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants