Merge pull request #422 from mimmi20/updates

fix property names
mimmi20 · Dec 8, 2023 · acdf54a · acdf54a
2 parents 12012d2 + 4e344c7
commit acdf54a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/.noai b/.noai
diff --git a/composer.json b/composer.json
@@ -36,11 +36,11 @@
     "friendsofphp/php-cs-fixer": "^v3.40.2",
     "sirbrillig/phpcs-variable-analysis": "^2.11.17",
     "slevomat/coding-standard": "^8.14.1",
-    "squizlabs/php_codesniffer": "^3.7.2"
+    "squizlabs/php_codesniffer": "^3.8.0"
   },
   "require-dev": {
     "phpstan/extension-installer": "^1.3.1",
-    "phpstan/phpstan": "^1.10.47",
+    "phpstan/phpstan": "^1.10.48",
     "phpstan/phpstan-deprecation-rules": "^1.1.4"
   },
   "minimum-stability": "stable",

diff --git a/phpstan.neon b/phpstan.neon
@@ -60,6 +60,9 @@ parameters:
   # reports properties with native types that weren’t initialized in the class constructor
   checkUninitializedProperties: true
 
+  # reports missing #[\Override] attribute
+  checkMissingOverrideMethodAttribute: true
+
   # doesn’t require typehints for properties if the types can be inferred from constructor injection
   inferPrivatePropertyTypeFromConstructor: false
 

diff --git a/src/Mimmi20CodingStandard/ruleset.xml b/src/Mimmi20CodingStandard/ruleset.xml
@@ -816,16 +816,16 @@
     <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes">
         <properties>
             <property
-                name="newlinesCountBetweenOpenTagAndDeclare"
-                value="2"
+                name="linesCountBeforeDeclare"
+                value="1"
             />
             <property
                 name="spacesCountAroundEqualsSign"
                 value="1"
             />
             <property
-                name="newlinesCountAfterDeclare"
-                value="2"
+                name="linesCountAfterDeclare"
+                value="1"
             />
         </properties>
     </rule>