Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os-speedtest-community: Error when attempting to install Ookla module #67

Closed
Greelan opened this issue Aug 15, 2021 · 10 comments
Closed

Comments

@Greelan
Copy link
Contributor

Greelan commented Aug 15, 2021

I recently reinstalled OPNsense as part of moving from UFS to ZFS, and as a result need to reinstall the speedtest plugin. I am running OPNsense 21.7.1 and os-speedtest-community 0.9_1.

I cannot now install the Ookla module. When attempting to do so I get the following in the logs for configd.py:

Script action failed with Command '/bin/sh /usr/local/opnsense/scripts/OPNsense/speedtest/install_speedtest.sh socket' returned non-zero exit status 1. at Traceback (most recent call last): File "/usr/local/opnsense/service/modules/processhandler.py", line 478, in execute subprocess.check_call(script_command, env=self.config_environment, shell=True, File "/usr/local/lib/python3.8/subprocess.py", line 364, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '/bin/sh /usr/local/opnsense/scripts/OPNsense/speedtest/install_speedtest.sh socket' returned non-zero exit status 1.

Be grateful for any suggestions.

@Greelan
Copy link
Contributor Author

Greelan commented Aug 15, 2021

I suspect this is related to the move from python 3.7 to 3.8 in 21.7? I see there are some other issues that also appear related to that, and note mimugmail's comment that the repo is being rebuilt. I might try a manual install in the meantime

@Greelan
Copy link
Contributor Author

Greelan commented Aug 15, 2021

Actually, manually running the script returns:

pkg: https://bintray.com/ookla/download/download_file?file_path=ookla-speedtest-1.0.0-freebsd.pkg: Forbidden

Going to that URL in a browser returns an error, on the basis that Bintray has been sunsetted from 1 May this year. Looks like the Ookla binary needs to be obtained from another source.

Ookla's website (https://www.speedtest.net/apps/cli) suggests the source should be:

https://install.speedtest.net/app/cli/ookla-speedtest-1.0.0-freebsd.pkg

Installing that package manually gets it working. 😀

@asche77
Copy link

asche77 commented Aug 18, 2021

On 21.7.1, neither installing the Speedtest nor the Ookla module (via GUI button) works for me.

@Greelan
Copy link
Contributor Author

Greelan commented Aug 18, 2021

I suspect with the speedtest module it is because the package name is now py38-speedtest-cli with the shift to Python 3.8, rather than py37-speedtest-cli as specified in the plugin script.

@asche77
Copy link

asche77 commented Aug 18, 2021

@Greelan , your suggestion for manual install works:
sudo pkg add "https://install.speedtest.net/app/cli/ookla-speedtest-1.0.0-freebsd.pkg"

@Greelan
Copy link
Contributor Author

Greelan commented Aug 18, 2021

I know 😀

Greelan added a commit to Greelan/opn-repo that referenced this issue Aug 21, 2021
Suggested changes to address mimugmail#67. The changes regarding speedtest-cli assume the system is using Python 3.8 (ie OPNsense 21.7 or later), and that it may have an older Python 3.7 speedtest-cli module installed if the plugin was used before OPNsense 21.7. There is probably a more robust way to implement this (for example, test which Python version is being used)?
@mimugmail
Copy link
Owner

The repo is now updated, please give it a try

@Greelan
Copy link
Contributor Author

Greelan commented Aug 31, 2021

Thanks. Do I need to reinstall the plugin to check? No update is showing when I check in the webgui. The glib package warning about the missing python37 dep is also still showing. Thanks

@mimugmail
Copy link
Owner

Please try again, stupid me :)

@Greelan
Copy link
Contributor Author

Greelan commented Aug 31, 2021

Lol. Works now, and updated script appears to work fine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants