Update for Ookla/speedtest-cli module changes #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested changes to address mimugmail#67. The changes regarding speedtest-cli assume the system is using Python 3.8 (ie OPNsense 21.7 or later), and that it may have an older Python 3.7 speedtest-cli module installed if the plugin was used before OPNsense 21.7. There is probably a more robust way to implement this (for example, test which Python version is being used)?
|
Thx! :) |
|
Thanks from the (absent) me too! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested changes to address #67. The changes regarding speedtest-cli assume the system is using Python 3.8 (ie OPNsense 21.7 or later), and that it may have an older Python 3.7 speedtest-cli module installed if the plugin was used before OPNsense 21.7. There is probably a more robust way to implement this (for example, test which Python version is being used)?