Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tense fix #184

Merged
merged 1 commit into from Apr 28, 2014
Merged

tense fix #184

merged 1 commit into from Apr 28, 2014

Conversation

brandondrew
Copy link
Contributor

The past participle of "to run" is just "run". "Ran" is the simple past tense. For example:

  • The program ran without errors.
  • The program has been run dozens of times.

@brandondrew
tense fix
c1e0a8a 
The past participle of "to run" is just "run".  "Ran" is the simple past tense.  For example:

* The program *ran* without errors.
* The program has been *run* dozens of times.
@rstacruz
Copy link
Member

My grammar can get very embarassing sometimes :)

@rstacruz
Copy link
Member

Thanks for the PR — i'll merge it in, but these also exist in the inline comments in the .rbs and will have to be cleaned up too.

rstacruz added a commit that referenced this pull request Apr 28, 2014
@rstacruz
Merge pull request #184 from brandondrew/patch-1
ed52704 
tense fix
@rstacruz rstacruz merged commit ed52704 into mina-deploy:master Apr 28, 2014
rstacruz added a commit that referenced this pull request Apr 28, 2014
@rstacruz
More fix on 'ran/run' tense errors in the comments. #184
583257e
@brandondrew
Copy link
Contributor Author

No need to feel embarrassed! And I'll be happy to fix inline comments in .rb files... might take a little while to get to...

@rstacruz
Copy link
Member

Got it too, 583257e :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandondrew @rstacruz