Conditional support for writing a REVISION file #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in mina-deploy#72 [0], having the exact sha of the deployed version of an application available in the root of the project can be very handy. For example: it's easy to retrieve the deployed version when the file is there. If the user now sets the `git_revision_file` in her `deploy.rb` config file: ``` set :git_revision_file, 'REVISION' ``` A file named 'REVISION' will be written during deployment which contains the sha of the project being deployed (obtained via `git rev-parse HEAD`). Existing projects won't noticed any difference since the `git_revision_file` flag must be set to have any effect on the deploy.
Since it would set nil and then + it, it would throw an error, now defaulting to "".
|
Ooh, yes please. I was just about to hack this in myself. |
|
duplicate of #306. closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #72 , having the exact sha of the deployed version of
an application available in the root of the project can be very
handy. For example: it's easy to retrieve the deployed version when the
file is there.
If the user now sets the
git_revision_filein herdeploy.rbconfigfile:
A file named 'REVISION' will be written during deployment which contains
the sha of the project being deployed (obtained via
git rev-parse HEAD).Existing projects won't noticed any difference since the
git_revision_fileflag must be set to have any effect on the deploy.