Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vectorisation option and some emcee compatibility #2

Closed
wants to merge 2 commits into from

Conversation

JohannesBuchner
Copy link
Contributor

Hi @minaskar,

Great work here! Thanks for creating zeus.

I am attaching a pull request that gives some emcee compatiblity, making it easier to use the samplers interchangably.

Some changes:

  • store log probability in samples, so they can be retrieved later
  • add some functions supported by emcee to allow interchangable runs
  • make samples axis order consistent with emcee

I just saw that this also addresses issue #1.

I hope these changes are of interest to you.

Cheers,
Johannes

store log probability in samples, so they can be retrieved later
add functions supported by emcee to allow interchangable runs
make samples axis order consistent with emcee
@minaskar
Copy link
Owner

Hi Johannes,

I just pushed a new update partially based on your insights, with only some minor differences (e.g. see the vectorise implementation).

Thanks a lot for your contributions!! If you have any other suggestions, feel free to submit another pull request.

Great work,
Minas

@JohannesBuchner
Copy link
Contributor Author

Ah, that's quite the elegant solution for the vectorize parameter :)

@minaskar minaskar closed this Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants