-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Download Progress #91
Comments
This would be pretty easy using the |
Not exactly what I meant, but it's something. I was talking about more of a On Mon, May 9, 2016 at 4:27 AM PalmerAL notifications@github.com wrote:
|
And what if you're downloading multiple files?
|
I'm not sure more clutter in the tabstrip is a good idea. Maybe something more similar to the Chrome download manager? |
So like, make the hamburger menu (three bars) do both task and download (kinda like chrome?) Or make it in one of the file/edit/view... menus |
I was thinking about having a bar at the bottom that shows up when you are downloading a file, and shows the download progress. When the file is done downloading, the bar would disappear. |
Oh that's what you meant! Well that's a good way too! Do whichever one you prefer! |
How about indicating a download in progress with a symbol on the tasks button, and show the details in the task view as a taks named "Downloads"? This would not add bload and will be consistent with the rest. |
Is there a new status on this? |
@PalmerAL Any news? |
@hmhofman It hasn't been a priority recently; we could probably get to it in the next couple releases. |
Came by looking for this. Just some way of seeing what downloads are active and their progress would be very welcome. : ) |
I'm hoping we can do this for 1.9. If we go with the bottom-bar approach, I think something like this would work: Clicking on the arrows would give you options to pause/cancel the download, and clicking on the file would open it. If anyone has opinions on this:
I might also make a mockup of having it in the tasks view; I like the idea of not taking up space to show the downloads, but it might also make it harder to find a downloaded file, and having two concepts (downloads and tasks) in the same screen might be confusing. |
I think that a bottom bar might "break" out of the theme/design though. EDIT: nvm, still unsure which one is best... |
Yeah, it has been a long time... hopefully this time we'll actually fix it! I think it might be worthwhile to make some mockups of different concepts first before actually implementing this. In particular, I have a couple of concerns about putting this in the task overlay:
However, I agree that it feels like the bottom bar doesn't really fit with the rest of the design. I tried making the bar use the site colors like the navbar does, but that didn't really look any better. I also considered having some kind of floating bubble near the bottom of the screen with the download, but I'm guessing that covering up content on the page would probably be an issue. |
Mockup of how having it in the tasks overlay could look: I don't think I like this as much, because it hides the downloads where it's harder to get to them, and makes it impossible to monitor download progress while still looking at a webpage, but if you want to download something in the background it would be less distracting. |
Hmm... Yeah, it doesn't look as good and it would require changing a lot of the design if we wanted to make it "fit in" better. The bottom-bar would probably be better, though I still feel like it somewhat "breaks" the design/theme of simplicity... EDIT: Perhaps making an entirely new button next to the task view button? Though that might be useless when the user has no downloads (I guess you could hide it until the user downloads something). And it might not look good either... |
It could just be a tab that can be opened? Via !downloads or via menu. Could have a preference option to auto-open the tab in background of the current task when you begin a new download. Edit: To chime in on the shared options, I think the 'Tasks' version fits most with the the minimal ideals of the browser. The downloads section concept presented above makes a lot of sense to me. It's seperate from the tasks, but easily discoverable. The Task view is a kind of nuetral ground to present that info. That said, I think a simple downloads tab also makes sense. |
Having a tab hides it even more in the background though, which I'm not sure we want. Generally, we want to hide things you aren't likely to use in order to simplify the UI, but if you're likely to use something, we don't want to make it any more difficult than it needs to be. Typically, when I download a file, I want to be able to glance at the download progress while doing something else, and when the file is done downloading, I want to open it immediately, but maybe this isn't typical. Are you typically downloading larger files? When a file finishes downloading, do you typically open it immediately, or do you wait a bit? I think it really just depends how likely people are to interact with the download manager. If it's something that you use every time you download a file, I think it makes a lot of sense to put it in the bottom, but if it's something that's used less frequently (such as when you want to check the progress of a particularly large download or cancel a download), it probably does make more sense to put it in the task overlay. |
I've implemented a prototype of the download bar here: https://github.com/minbrowser/min/tree/download-manager. Not quite everything works yet (the popup menu, the button to close the bar), but it should be enough to figure out if this is the right approach or not. I ended up simplifying the bar a bit more to make it less distracting: It still seems a bit more intrusive than I'd like, but I'd like to find out what you think as well. @pandawanfr @clayton-grey (and anyone else who's interested), could you try out that branch and see how well it works for you? (In particular, does it seem distracting if you're trying to do something else with a file downloading in the background?) |
@PalmerAL I gave this a test on the download-manager branch. I see you had a progress bar it looks like in your screen shot but when I downloaded something on windows I didn't see a progress bar. |
@PalmerAL I did a little more testing an ran into another issue. Take a look at the screenshot below. Looks like when the text wraps it doesn't display correctly. See screenshot |
@PalmerAL looks like the wrapping is fixed but the progress bar still isn't there. |
OK, it is a different issue, should be fixed in 0f40e2c. |
That fixed it :) |
I've opened a PR for this here: #671. |
I've merged #671; while this isn't the perfect solution, I think it's a good balance between being minimalistic and being easy to use. A lot of this code is reusable, so if we decide to move download information to the task overlay later, it shouldn't require too many changes to do that. |
Currently all downloads are inivisible, a dialog box confirming location pops up but thereafter, we don't get to see the download progress. this is suboptimal and needs to be fixed in some future version.
The text was updated successfully, but these errors were encountered: