Skip to content

Commit

Permalink
Remove deprecated types (#156)
Browse files Browse the repository at this point in the history
### Summary
- Remove deprecated types: `BearerOAuth2Token`, `OAuth2TokenAES256CBCCipher`, and `OAuth2TokenDiskStore`
- Set `IPHONEOS_DEPLOYMENT_TARGET` to 9.0 for all Conduit targets
  • Loading branch information
eneko committed Oct 8, 2020
1 parent 2c77175 commit 6aa00e3
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 492 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## master

#### Breaking
- None
- Remove deprecated types: `BearerOAuth2Token`, `OAuth2TokenAES256CBCCipher`, and `OAuth2TokenDiskStore`

#### Enhancements
- None
Expand Down
50 changes: 6 additions & 44 deletions Conduit.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

72 changes: 0 additions & 72 deletions Sources/Conduit/Auth/Models/OAuth2LegacyToken.swift

This file was deleted.

7 changes: 0 additions & 7 deletions Sources/Conduit/Auth/Models/OAuth2Token.swift
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,6 @@ extension BearerToken {
}
}

extension BearerToken {
@available(*, deprecated, message: "BearerOAuth2Token will be removed in a future version.")
init(legacyToken: BearerOAuth2Token) {
self.init(accessToken: legacyToken.accessToken, refreshToken: legacyToken.refreshToken, expiration: legacyToken.expiration)
}
}

extension BasicToken {
func base64EncodedUsernameAndPassword() -> String {
let usernamePasswordString = "\(username):\(password)"
Expand Down
7 changes: 3 additions & 4 deletions Sources/Conduit/Auth/OAuth2RequestPipelineMiddleware.swift
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,10 @@ public struct OAuth2RequestPipelineMiddleware: RequestPipelineMiddleware {
let tokenStorage: OAuth2TokenStore

var token: BearerToken? {
if let token: BearerToken = tokenStorage.tokenFor(client: clientConfiguration, authorization: authorization) {
return token
guard let token: BearerToken = tokenStorage.tokenFor(client: clientConfiguration, authorization: authorization) else {
return nil
}
let legacyToken: BearerOAuth2Token? = tokenStorage.tokenFor(client: clientConfiguration, authorization: authorization)
return legacyToken?.converted
return token
}

/// Creates a new OAuth2RequestPipelineMiddleware
Expand Down
64 changes: 0 additions & 64 deletions Sources/Conduit/Auth/TokenStorage/OAuth2TokenAES256CBCCipher.swift

This file was deleted.

123 changes: 0 additions & 123 deletions Sources/Conduit/Auth/TokenStorage/OAuth2TokenDiskStore.swift

This file was deleted.

26 changes: 0 additions & 26 deletions Tests/ConduitTests/Auth/OAuth2RequestPipelineMiddlewareTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -309,32 +309,6 @@ class OAuth2RequestPipelineMiddlewareTests: XCTestCase {
waitForExpectations(timeout: 1)
}

func testLegacyTokenMigration() throws {
let randomToken = BearerOAuth2Token(accessToken: randomTokenAccessToken, refreshToken: "notused", expiration: Date().addingTimeInterval(1_000_000))
let authorization = OAuth2Authorization(type: .bearer, level: .user)
let validClientConfiguration = try makeValidClientConfiguration()

let tokenStorage = OAuth2TokenMemoryStore()
tokenStorage.store(token: randomToken, for: validClientConfiguration, with: authorization)

let request = try makeDummyRequest()
let sut = OAuth2RequestPipelineMiddleware(clientConfiguration: validClientConfiguration, authorization: authorization, tokenStorage: tokenStorage)

let decorateRequestExpectation = expectation(description: "request immediately decorated")
sut.prepareForTransport(request: request) { result in
guard case .value(let request) = result else {
XCTFail("No value")
return
}
XCTAssert(request.allHTTPHeaderFields?["Authorization"] == randomToken.authorizationHeaderValue)
decorateRequestExpectation.fulfill()
}

XCTAssertNotNil(sut.token)

waitForExpectations(timeout: 0.1)
}

func testCoordinatesRefreshesBetweenMultipleSessions() throws {
/// Simulates multiple sessions (different processes) triggering token refreshes at once

Expand Down
46 changes: 0 additions & 46 deletions Tests/ConduitTests/Auth/OAuth2TokenAES256CBCCipherTests.swift

This file was deleted.

Loading

0 comments on commit 6aa00e3

Please sign in to comment.