Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes / docs] Add more vocabs / Fix Style / HF hub / API Dep #1412

Merged
merged 8 commits into from
Jan 3, 2024

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Dec 21, 2023

This PR:

  • adds some more vocabs and updated doc
  • fix HF hub upload (increased to >=0.20)
  • fix style
  • remove onnx constraint
  • fix api dep (TF needs py 3.9)
  • Add two new custom models to the docs list

Any feedback is welcome 🤗

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (5105f98) 95.76% compared to head (3540e11) 95.79%.

Files Patch % Lines
doctr/io/elements.py 33.33% 2 Missing ⚠️
doctr/models/builder.py 0.00% 1 Missing ⚠️
doctr/models/recognition/parseq/pytorch.py 0.00% 1 Missing ⚠️
doctr/models/recognition/parseq/tensorflow.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1412      +/-   ##
==========================================
+ Coverage   95.76%   95.79%   +0.03%     
==========================================
  Files         155      155              
  Lines        6942     6950       +8     
==========================================
+ Hits         6648     6658      +10     
+ Misses        294      292       -2     
Flag Coverage Δ
unittests 95.79% <87.17%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 added this to the 0.8.0 milestone Dec 21, 2023
@felixdittrich92 felixdittrich92 added topic: documentation Improvements or additions to documentation type: enhancement Improvement module: datasets Related to doctr.datasets type: code quality Related to code quality ext: docs Related to docs folder labels Dec 21, 2023
@felixdittrich92 felixdittrich92 marked this pull request as ready for review December 21, 2023 09:08
@felixdittrich92 felixdittrich92 changed the title Add some more vocabs and fix style [Fixes / docs] Add more vocabs / Fix Style / HF hub / API Dep Dec 22, 2023
@felixdittrich92
Copy link
Contributor Author

Some minor stuff bundled into the PR

@felixdittrich92 felixdittrich92 added the topic: build Related to dependencies and build label Dec 29, 2023
pyproject.toml Show resolved Hide resolved
doctr/datasets/vocabs.py Show resolved Hide resolved
@felixdittrich92
Copy link
Contributor Author

@odulcy-mindee are you fine if we fix the mypy issues in another PR ? Otherwise it blows up more and more 😅

@odulcy-mindee
Copy link
Collaborator

@odulcy-mindee are you fine if we fix the mypy issues in another PR ? Otherwise it blows up more and more 😅

Yeah, that's fine 👍

@felixdittrich92 felixdittrich92 merged commit ed927bd into mindee:main Jan 3, 2024
65 of 67 checks passed
@felixdittrich92 felixdittrich92 deleted the vocabs-and-style branch January 3, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs Related to docs folder module: datasets Related to doctr.datasets topic: build Related to dependencies and build topic: documentation Improvements or additions to documentation type: code quality Related to code quality type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants