fix: Removed PDF forced square resize from demo & analysis script #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fg-mindee
added
type: enhancement
Codecov Report
@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 96.18% 96.15% -0.03%
==========================================
Files 83 83
Lines 3461 3461
==========================================
- Hits 3329 3328 -1
- Misses 132 133 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the resizing step of PDF image rendering to square images. The reason behind that is that while it's indeed optimized if the predictor target size is that specific size if there are multiple preprocessors inside, it yields double interpolation.
Any feedback is welcome!