Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MobilenetV3 (Tensorflow) #372

Merged
merged 13 commits into from
Aug 3, 2021
Merged

feat: add MobilenetV3 (Tensorflow) #372

merged 13 commits into from
Aug 3, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR implements MobilenetV3 (both small & large) in tensorflow backbones.
Any feedback is welcome!

@charlesmindee charlesmindee self-assigned this Jul 8, 2021
@charlesmindee charlesmindee added type: enhancement Improvement module: models Related to doctr.models labels Jul 8, 2021
@charlesmindee charlesmindee added this to the 0.3.1 milestone Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #372 (339088e) into main (7f9c305) will increase coverage by 0.06%.
The diff coverage is 98.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   95.79%   95.86%   +0.06%     
==========================================
  Files          89       91       +2     
  Lines        3690     3748      +58     
==========================================
+ Hits         3535     3593      +58     
  Misses        155      155              
Flag Coverage Δ
unittests 95.86% <98.33%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/backbones/mobilenet/tensorflow.py 98.14% <98.14%> (ø)
doctr/models/backbones/__init__.py 100.00% <100.00%> (ø)
doctr/models/backbones/mobilenet/__init__.py 100.00% <100.00%> (ø)
doctr/models/utils/tensorflow.py 100.00% <100.00%> (ø)
doctr/models/core.py 94.95% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9c305...339088e. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added some comments

doctr/models/backbones/mobilenet/tensorflow.py Outdated Show resolved Hide resolved
doctr/models/backbones/mobilenet/tensorflow.py Outdated Show resolved Hide resolved
doctr/models/backbones/mobilenet/tensorflow.py Outdated Show resolved Hide resolved
doctr/models/backbones/mobilenet/tensorflow.py Outdated Show resolved Hide resolved
doctr/models/backbones/mobilenet/tensorflow.py Outdated Show resolved Hide resolved
doctr/models/backbones/mobilenet/tensorflow.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! just changing the naming and factory functions and we're good for merge!

doctr/models/backbones/mobilenet/tensorflow.py Outdated Show resolved Hide resolved
doctr/models/backbones/mobilenet/tensorflow.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@charlesmindee charlesmindee merged commit d5afb3e into main Aug 3, 2021
@charlesmindee charlesmindee deleted the mobilenet branch August 3, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models Related to doctr.models type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants