-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WeasyPrint version compatibility with Python 3.7 #404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I suggested an extra flexibility of weasyprint version constraints rather than pinning it
Codecov Report
@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 95.88% 95.91% +0.02%
==========================================
Files 91 91
Lines 3795 3795
==========================================
+ Hits 3639 3640 +1
+ Misses 156 155 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR forces the weasyprint version to 52.5 because we have a bug showing up with the 53.0 version with python 3.7
Any feedback is welcome!
Closes #401