Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WeasyPrint version compatibility with Python 3.7 #404

Merged
merged 13 commits into from
Aug 10, 2021
Merged

Conversation

charlesmindee
Copy link
Collaborator

This PR forces the weasyprint version to 52.5 because we have a bug showing up with the 53.0 version with python 3.7
Any feedback is welcome!

Closes #401

@charlesmindee charlesmindee self-assigned this Aug 9, 2021
@charlesmindee charlesmindee added type: bug Something isn't working critical High priority module: io Related to doctr.io labels Aug 9, 2021
@charlesmindee charlesmindee added this to the 0.3.1 milestone Aug 9, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I suggested an extra flexibility of weasyprint version constraints rather than pinning it

requirements.txt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #404 (4945947) into main (d15725a) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   95.88%   95.91%   +0.02%     
==========================================
  Files          91       91              
  Lines        3795     3795              
==========================================
+ Hits         3639     3640       +1     
+ Misses        156      155       -1     
Flag Coverage Δ
unittests 95.91% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/core.py 94.95% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15725a...4945947. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charlesmindee charlesmindee merged commit 26f2167 into main Aug 10, 2021
@charlesmindee charlesmindee deleted the weasy branch August 10, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical High priority module: io Related to doctr.io type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WeasyPrint import error Python 3.7
2 participants