Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added character generator dataset #412

Merged
merged 9 commits into from
Aug 13, 2021
Merged

feat: Added character generator dataset #412

merged 9 commits into from
Aug 13, 2021

Conversation

fg-mindee
Copy link
Contributor

Following up on #262, this PR introduces the following modifications:

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement module: io Related to doctr.io ext: tests Related to tests folder module: datasets Related to doctr.datasets framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend labels Aug 13, 2021
@fg-mindee fg-mindee added this to the 0.4.0 milestone Aug 13, 2021
@fg-mindee fg-mindee self-assigned this Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #412 (5d8942f) into main (86daa0f) will decrease coverage by 0.01%.
The diff coverage is 95.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   95.80%   95.78%   -0.02%     
==========================================
  Files          91       95       +4     
  Lines        3838     3917      +79     
==========================================
+ Hits         3677     3752      +75     
- Misses        161      165       +4     
Flag Coverage Δ
unittests 95.78% <95.60%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/classification/base.py 90.62% <90.62%> (ø)
doctr/io/image/tensorflow.py 91.66% <94.11%> (+1.66%) ⬆️
doctr/datasets/__init__.py 100.00% <100.00%> (ø)
doctr/datasets/classification/__init__.py 100.00% <100.00%> (ø)
doctr/datasets/classification/pytorch.py 100.00% <100.00%> (ø)
doctr/datasets/classification/tensorflow.py 100.00% <100.00%> (ø)
doctr/datasets/loader.py 100.00% <100.00%> (ø)
doctr/io/image/pytorch.py 93.75% <100.00%> (+1.44%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86daa0f...5d8942f. Read the comment docs.

@fg-mindee fg-mindee merged commit 7074c0a into main Aug 13, 2021
@fg-mindee fg-mindee deleted the char-classif branch August 13, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend module: datasets Related to doctr.datasets module: io Related to doctr.io type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant