-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MNIST-like characters dataset generator #408
Conversation
Codecov Report
@@ Coverage Diff @@
## main #408 +/- ##
==========================================
- Coverage 95.83% 95.82% -0.01%
==========================================
Files 91 92 +1
Lines 3815 3833 +18
==========================================
+ Hits 3656 3673 +17
- Misses 159 160 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
To make it more modular, could you turn your function into something deterministic please?
- one to generate an image for a given character
(if later on, we use this for random generation, we'll just have to randomly pick within a vocab)
Also we need some unittests, and mypy isn't happy 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few improvement suggestions in comments!
Also quick suggestion: let's produce straight characters (we'll be able to use transforms afterwards to rotate the characters if needed) |
This PR implements a generate_character function to generate random single character images from a vocabulary to train our recognition backbones.
Linked to #255
Any feedback is welcome!
Samples: