Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: performances update following up the crop splitting feature #471

Merged
merged 15 commits into from
Sep 15, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR adds the benchmark of all models with the new crop splitting feature activated, for some datasets it changes almost nothing, but for our private datasets (especially IDS with a lot of MRZ) it improves significantly performances and beyond that results are far more consistent when dealing with extremely long sequences, even if the exact match metric does not always reflect that (one small mistake over 45 chars is better than 45 mistakes...).

Any feedback is welcome!

@charlesmindee charlesmindee added the topic: documentation Improvements or additions to documentation label Sep 14, 2021
@charlesmindee charlesmindee added this to the 0.4.0 milestone Sep 14, 2021
@charlesmindee charlesmindee self-assigned this Sep 14, 2021
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #471 (fd7de48) into main (a735821) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   95.79%   95.76%   -0.03%     
==========================================
  Files          95       95              
  Lines        3992     3992              
==========================================
- Hits         3824     3823       -1     
- Misses        168      169       +1     
Flag Coverage Δ
unittests 95.76% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 91.35% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a735821...fd7de48. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@charlesmindee charlesmindee merged commit 3fec8be into main Sep 15, 2021
@charlesmindee charlesmindee deleted the bench branch September 15, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants