Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixed keras version constraint #579

Merged
merged 1 commit into from
Nov 4, 2021
Merged

chore: Fixed keras version constraint #579

merged 1 commit into from
Nov 4, 2021

Conversation

fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Nov 4, 2021

This PR tries to fix the CI issue that happens since the release of keras 2.7 https://github.com/keras-team/keras/releases/tag/v2.7.0 by constraining the version to a lower index.

cf. tensorflow/tensorflow#52937 & keras-team/keras#15585

Any feedback is welcome!

@fg-mindee fg-mindee added critical High priority topic: build Related to dependencies and build framework: tensorflow Related to TensorFlow backend labels Nov 4, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Nov 4, 2021
@fg-mindee fg-mindee self-assigned this Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #579 (2bb6a4c) into main (92c1eeb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #579   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         109      109           
  Lines        4236     4236           
=======================================
  Hits         4069     4069           
  Misses        167      167           
Flag Coverage Δ
unittests 96.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c1eeb...2bb6a4c. Read the comment docs.

@fg-mindee fg-mindee merged commit 781f47a into main Nov 4, 2021
@fg-mindee fg-mindee deleted the dep-fix branch November 4, 2021 11:57
@fg-mindee
Copy link
Contributor Author

Merged this one as it's a critical issue

@frgfm frgfm mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical High priority framework: tensorflow Related to TensorFlow backend topic: build Related to dependencies and build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant