Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIIT-5K dataset integration #589

Merged
merged 18 commits into from
Nov 12, 2021
Merged

IIIT-5K dataset integration #589

merged 18 commits into from
Nov 12, 2021

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Nov 8, 2021

This PR integrates the IIIT-5K dataset recognition part

TODO:
upload dataset:
TRAIN
TEST

@fg-mindee
Can you add both and send me SHA and URL ?

Issues:
#587

@fg-mindee
Copy link
Contributor

Hi there 👋

Considering IIIT-5K is available publicly, let's use the public URL rather than reuploading it :)

@fg-mindee fg-mindee self-requested a review November 8, 2021 14:14
@fg-mindee fg-mindee self-assigned this Nov 8, 2021
@fg-mindee fg-mindee added topic: documentation Improvements or additions to documentation module: datasets Related to doctr.datasets ext: tests Related to tests folder labels Nov 8, 2021
@fg-mindee fg-mindee added this to the 1.0.0 milestone Nov 8, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix! I added a few comments, let me know what you think 👌

doctr/datasets/datasets/base.py Show resolved Hide resolved
doctr/datasets/iiit5k.py Show resolved Hide resolved
doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
doctr/datasets/iiit5k.py Show resolved Hide resolved
doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
test/pytorch/test_datasets_pt.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #589 (081dc08) into main (a792a82) will increase coverage by 0.12%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   96.03%   96.15%   +0.12%     
==========================================
  Files         110      111       +1     
  Lines        4265     4296      +31     
==========================================
+ Hits         4096     4131      +35     
+ Misses        169      165       -4     
Flag Coverage Δ
unittests 96.15% <97.05%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/iiit5k.py 96.77% <96.77%> (ø)
doctr/datasets/__init__.py 100.00% <100.00%> (ø)
doctr/datasets/datasets/base.py 95.45% <100.00%> (-0.11%) ⬇️
doctr/utils/data.py 98.11% <0.00%> (+9.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a792a82...081dc08. Read the comment docs.

@felixdittrich92 felixdittrich92 marked this pull request as ready for review November 8, 2021 15:37
@felixdittrich92 felixdittrich92 changed the title [WIP] IIIT-5K dataset integration IIIT-5K dataset integration Nov 8, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits! I suggest reverting the changes about the target_task and this will apply to all datasets and is not related to this PR goal directly :)

doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last suggestions and we're good :)

doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
doctr/datasets/iiit5k.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot @felixdittrich92 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants