Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Specified comment in SAR about symbol encoding #617

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR specifies the reason of the one hot symbol encoding in the SAR decoder following up on #578.

cc @khalidMindee

@fg-mindee fg-mindee added topic: documentation Improvements or additions to documentation module: models Related to doctr.models topic: text recognition Related to the task of text recognition labels Nov 12, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Nov 12, 2021
@fg-mindee fg-mindee self-assigned this Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #617 (0b187e2) into main (f97e92b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         110      110           
  Lines        4265     4265           
=======================================
  Hits         4097     4097           
  Misses        168      168           
Flag Coverage Δ
unittests 96.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/sar/pytorch.py 98.34% <ø> (ø)
doctr/models/recognition/sar/tensorflow.py 98.49% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97e92b...0b187e2. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@fg-mindee fg-mindee merged commit f03ec3c into main Nov 15, 2021
@fg-mindee fg-mindee deleted the sar-comment branch November 15, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models Related to doctr.models topic: documentation Improvements or additions to documentation topic: text recognition Related to the task of text recognition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants